Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build apisix-openresty base on alpine #97

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

feat: build apisix-openresty base on alpine #97

wants to merge 30 commits into from

Conversation

gxthrj
Copy link
Contributor

@gxthrj gxthrj commented Sep 22, 2021

No description provided.

@gxthrj gxthrj marked this pull request as ready for review September 26, 2021 00:57
spacewander
spacewander reviewed Sep 26, 2021
View reviewed changes
Copy link
Contributor

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the build result in the CI

dockerfiles/Dockerfile.apisix-openresty.apk Outdated
ARG RESTY_OPENSSL_URL_BASE="https://www.openssl.org/source"
ARG RESTY_PCRE_VERSION="8.44"
ARG RESTY_J="1"
ARG RESTY_CONFIG_OPTIONS="\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unused ARG/labels

spacewander
spacewander reviewed Oct 14, 2021
View reviewed changes
Copy link
Contributor

@spacewander spacewander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a workflow to verify the build?

@spacewander
Copy link
Contributor

Look like we need to use glibc for Alpine?

@gxthrj
Copy link
Contributor Author

gxthrj commented Oct 15, 2021

Look like we need to use glibc for Alpine?

I used https://github.com/sgerrand/alpine-pkg-glibc , but still failed.

spacewander
spacewander reviewed Oct 19, 2021
View reviewed changes
dockerfiles/Dockerfile.apisix.alpine
@@ -0,0 +1,55 @@
ARG ENABLE_PROXY=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacewander spacewander spacewander left review comments

@imjoey imjoey Awaiting requested review from imjoey

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gxthrj @spacewander